Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document -tagged, -not -tagged, and -not -starred #1684

Merged
merged 1 commit into from
Mar 4, 2023

Conversation

micahellison
Copy link
Member

@micahellison micahellison commented Feb 20, 2023

Fixes #1668. Documents the behavior modified in #1663.

In the long run, I think we'll want a more polymorphic approach to documenting -not, but since it only supports three different inputs and two of them are already search arguments, I thought it best to keep it all separate for now. This also helps with the table layout on the site, since it can't be widened nicely in our current docs style.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.

@micahellison micahellison added the documentation Improvements or additions to documentation label Feb 20, 2023
Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great clarifications!

Can you add this to the help screen at the same time, please?

@micahellison
Copy link
Member Author

Can you add this to the help screen at the same time, please?

Turns out this was already done in the original PR, and looks pretty good to me:

  -not [TAG/FLAG]       If passed a string, will exclude entries with that tag.
                        Can be also used before -starred or -tagged flags, to
                        exclude starred or tagged entries respectively.

Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏷️

@wren wren merged commit e54908b into jrnl-org:develop Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document -tagged, -not -tagged, and -not -starred
2 participants