Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic template test #1659

Merged
merged 4 commits into from
Jan 7, 2023
Merged

Add basic template test #1659

merged 4 commits into from
Jan 7, 2023

Conversation

micahellison
Copy link
Member

#1653 mentions that there are no template tests (thank you @Briscoooe for noticing this!). I just wanted to get the ball rolling with a process for copying the templates to the sample directory and confirming that a template is used in a new entry.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.

@micahellison micahellison added the test Issues related to tests we need to add label Jan 7, 2023
Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🎸

@wren wren merged commit 9274ab1 into jrnl-org:develop Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues related to tests we need to add
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants