This repository has been archived by the owner on Apr 29, 2021. It is now read-only.
Optimize "if-else" children #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer present in Babel 6
In JSX, since there’s not if-else statements, most people use `condition ? <div /> : <other />` or `condition && <div /> || <other />` to conditional render children. This optimizes them so they do not require a JSX wrapper. Fixes #57.
Anything that gets a reference to a JSX element will deoptimize into a wrapper
So a JSX element in the last position means we don’t need to arbitrarily render.
jridgewell
force-pushed
the
if-then-children
branch
from
ac510d1
to
6dafa98
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In JSX, since there’s not if-else statements, most people use
condition ? <div /> : <other />orcondition && <div /> || <other />to conditionally render children.This optimizes them so they do not require a JSX wrapper.
Fixes #57.