-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compare two graphs #87
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #87 +/- ##
==========================================
- Coverage 86.89% 83.71% -3.19%
==========================================
Files 1 1
Lines 2290 2334 +44
==========================================
- Hits 1990 1954 -36
- Misses 300 380 +80 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise looks ok.
Requiring exact same structure is an annoying limitation -- for example, for sampling profilers, graphs can easily change. But this is a step forward nevertheless. A simple solution to this would be to insert the missing nodes/edges with zero weight to ensure graphs are the same.
Also, we should add some test coverage for this, to ensure this doesn't break. |
I added some tests (not sure if satisfying) and resolved tasks from you. When it comes to not requiring exact same structure I will try to tackle this in the near future. |
I've rebased this PR, squashed, and merged it as 4d8a733. Thank you |
Description
This Pull Request introduces a new feature to compare two graphs with identical structures. The added functionality allows users to analyze differences in performance metrics, such as time or function calls, between two graphs generated from profiling data.
Changes Made
--compare
functionality.Additional Notes