This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Add Prometheus provider for external metrics check during autoscaling #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A scaling policy can now include a list of external checks which are evaluated during the autoscaling run. Initially Prometheus can be used, but additional providers can be added providing the policy is updated and the metrics interface is statisfied.
jrasell
added
kind/enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A scaling policy can now contain external checks which pull a metric value from an external provider and evaluate this agains the threshold configured. If the threshold is broken, the configured action will be requested.
The change also makes the Nomad resource calculation checks optional when running the autoscaler, allowing user to only use external checks if they wish or a combination. The autoscaler does a number of decision steps, in order to make sure both Nomad and external check evaluations are taken into account before requesting action.
closes #102