Autocomplete: Rewrite with a delay instead of appending the live region #2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bbenjamin
changed the title
mgol
reviewed
Dec 10, 2021
mgol
reviewed
Dec 10, 2021
fnagel
requested changes
Dec 14, 2021
mgol
approved these changes
Dec 17, 2021
fnagel
requested changes
Dec 20, 2021
|
I tested this locally and it works fine for me. I'll wait a bit for Felix to say whether he had any other concerns and I'll land it, making the changes requested by Felix by myself if @bbenjamin isn't available to do that. |
fnagel
approved these changes
Jan 3, 2022
mgol
changed the title
|
Landed, thanks! |
|
jQuery UI 1.13.1 including this fix has been released: https://blog.jqueryui.com/2022/01/jquery-ui-1-13-1-released/. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential solution for #2002. The bug is due to changes https://bugs.jqueryui.com/ticket/9357. This addresses the bug without undoing the fix reported there. Instead, it empties the live region instead of appending, and does so after a brief timeout so the live region isn't updated on every mousemove event or when quickly traversing through options