Build: Switch from Travis to GitHub actions #2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
reviewed
Nov 23, 2021
mgol
reviewed
Nov 23, 2021
.github/workflows/test.yml
Outdated
Comment on lines
3
to
12
| on: | ||
| push: | ||
| branches: | ||
| - '*' | ||
| pull_request: | ||
| types: | ||
| - opened | ||
| - edited | ||
| - reopened | ||
| - synchronize |
There was a problem hiding this comment.
Should we try to rely more on defaults here, like in https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#example-using-a-list-of-events?
Suggested change
| on: | |
| push: | |
| branches: | |
| - '*' | |
| pull_request: | |
| types: | |
| - opened | |
| - edited | |
| - reopened | |
| - synchronize | |
| on: [push, pull_request] |
In particular, the edited event seems to run when a review is edited if I understand it correctly. Docs are pretty scarce on what each event means, unfortunately...
There was a problem hiding this comment.
I copied this from one of my projects and afair I did this so tags don't trigger a run as my project had much more jobs and was "expensive". Let's go with the default and change it if needed. I've changed this to your suggestion.
Replaces Travis functionality.
Travis has been replaced with GitHub Actions. See 63c98b8
fnagel
force-pushed
the
tests-github-actions
branch
from
4a06009 to
e73861b
Compare
fnagel
commented
Nov 25, 2021
mgol
approved these changes
Nov 30, 2021
mgol
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces Travis functionality.
Follow up tasks: