Sortable: Allow 0-height containers to be sortable as in 1.12.1 #2008
Conversation
Note that container specific events will not fire when the dragged element is interacting with zero height containers. Fixes jquerygh-1998 Co-Authored-By: A. Wells <[email protected]>
mgol
force-pushed
the
sortable-0-height-container-gh-1998
branch
from
f4d0a0e to
855cf76
Compare
|
Ouch; I've just discovered the fix only allows the first drag; a second & subsequent ones are still broken just like before. I pushed a test modification that fails due to this. More changes will be needed... |
|
@borgboyone In addition to the changes you described, I also had to remove the This removed all occurrences of |
| function step1() { | ||
| el.find( "li" ).eq( 0 ).simulate( "drag", { | ||
| dx: 100, | ||
| dy: 3, |
There was a problem hiding this comment.
@fnagel I'm not sure why dy matters here since we're dragging horizontally but it had a visible effect on the test... I'm not sure if it's an actual issue or just a jQuery Simulate quirk but in manual testing it seemed to work fine so I gave up on debugging this.
There was a problem hiding this comment.
Sorry, I'm not really helpful here, but I guess you are right: could be a jQuery Simulate quirk too.
Having some tests should be fine...
|
@mgol - Smart move on removing the other checks for innermostContainer as this point. FYI: As I see it, you'll want to leave L892...just remove L891 and L893.
|
Yes, sorry for not being clear, I edited my comment. |
|
jQuery UI 1.13.1 including this fix has been released: https://blog.jqueryui.com/2022/01/jquery-ui-1-13-1-released/. |
Note that container specific events will not fire when the dragged element
is interacting with zero height containers.
Fixes gh-1998
Co-Authored-By: A. Wells <[email protected]>