Accordion: Set aria-expanded when collapsing
#1413
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #10703
| @@ -499,7 +502,7 @@ return $.widget( "ui.accordion", { | |||
| }); | |||
| } else if ( toShow.length ) { | |||
| this.headers.filter(function() { | |||
| return $( this ).attr( "tabIndex" ) === 0; | |||
| return $( this ).attr( "tabIndex" ) === "0"; | |||
There was a problem hiding this comment.
I didn't check this in all browsers. The value is supposed to be an integer, but since attributes are strings, that's what we get back. @jquery/core Is this the best way to do this check or should we parseInt()?
There was a problem hiding this comment.
AFAIK IE8 is fine here; IE<8 have attroperties and they return numbers but you don't support IE<8 so it should be good.
There was a problem hiding this comment.
You probably want to use parseInt for the best compat. I think on older versions core returns a number when it should return a string. Looks like it changed in 1.8.something http://jsfiddle.net/qvpq4wo1/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10703