Build: Make Migrate properly recognized as a CommonJS module in Node.js #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR jquerygh-512 added the `"type": "module"` field to the top-level `package.json`, making Node-based workflows fail when trying to require Migrate as it's not exposed as ESM. To fix this, add a small `package.json` with just `"type": "commonjs"`. Also, add Node.js smoke tests as the simplest way to verify this change. Fixes jquerygh-523 Ref jquerygh-512
timmywil
approved these changes
Jul 16, 2024
|
Released in jQuery Migrate |
This was referenced Aug 9, 2024
This was referenced Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR gh-512 added the
"type": "module"field to the top-levelpackage.json, making Node-based workflows fail when trying to require Migrate as it's not exposed as ESM. To fix this, add a smallpackage.jsonwith just"type": "commonjs". Also, add Node.js smoke tests as the simplest way to verify this change.Fixes gh-523
Ref gh-512
Actions run from the base branch version, so to verify this PR I changed the base branch on my fork & I submitted a draft PR at mgol#1. The first commit with small changes passed:
https://github.com/mgol/jquery-migrate/actions/runs/9947009305/job/27478759025?pr=1
while the second one removing the
dist/package.jsonthat this PR adds failed as expected:https://github.com/mgol/jquery-migrate/actions/runs/9947022296/job/27478796641?pr=1