Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.scrollTop(): document proper use of scrollTop on document body #425

Closed
wants to merge 1 commit into from

Conversation

leobalter
Copy link
Member

Fixes #417

I also have included more text for clarification. (can change it if you want)

@gnarf
Copy link
Member

gnarf commented Jan 28, 2014

I don't like the wording of:

Note that scrollTop can be used to read, but not write, the document scroll position.

It seems that we might be better off saying something like

If you want to read or write the scrollTop() for the whole document, you should use the body element, not window or document or html.

Not sure my wording is any better, but feels less "archaic"

@gnarf
Copy link
Member

gnarf commented Jan 28, 2014

Also, does this also apply to scrollLeft()?

@jzaefferer
Copy link
Member

Thanks for the PR. Since the original Core issue was reopened, I'm going to close this one for now, until the underlying issue is resolved.

@jzaefferer jzaefferer closed this Jan 29, 2014
@leobalter leobalter deleted the 417-proper-scrolltop branch January 29, 2014 16:15
@leobalter leobalter restored the 417-proper-scrolltop branch January 29, 2014 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Document how to use scrollTop() properly
3 participants