This repository has been archived by the owner on Dec 11, 2021. It is now read-only.
Images : Basic styling #149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejdeep
force-pushed
the
image-styling
branch
3 times, most recently
from
e507a23 to
2368a6b
Compare
| .img-responsive { | ||
| @include img(); | ||
| display: block; | ||
| max-width: 100%; |
There was a problem hiding this comment.
Isn't this redundant since it's already in the mixin?
thejdeep
force-pushed
the
image-styling
branch
3 times, most recently
from
5ddc392 to
e26866d
Compare
| @@ -39,7 +39,7 @@ | |||
| } | |||
|
|
|||
| .btn { | |||
| @include btn( map-get($ui-btn, margin)); | |||
| @include btn(map-get($ui-btn, margin)); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Probably shouldn't make these changes as part of this PR, since this PR is image focused
Images : Initial commit
|
Can you please rebase this with what is currently in master? there are some naming changes that breaks your code. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base styling for image classes. Fixes #148