This repository was archived by the owner on Feb 11, 2021. It is now read-only.
Fix touchEvent support for touch-action #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 30, 2013 20:35
Change HAS_TOUCH_ACTION to HAS_TOUCH_ACTION_DELAY. Even with touch-action we should still avoid unnecessary touch handlers. It's only with touch-action-delay: none that we can be sure our handlers won't delay threaded scrolling. This works around jquery-archive#116 for now without actually solving it completely.
Chrome 33 has a bug where the CSS OM objects exist for touchActionDelay even though parsing will always fail for them, so we'd incorrectly believe support was present. Let's wait until there's actually a Chrome build to test before trying to enable a touch-action-delay fast-path.
|
LGTM. |
dfreedm
added a commit
that referenced
this pull request
Dec 31, 2013
Fix touchEvent support for touch-action
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change HAS_TOUCH_ACTION to HAS_TOUCH_ACTION_DELAY. Even with touch-action we should still avoid unnecessary touch handlers. It's only with touch-action-delay: none that we can be sure our handlers won't delay threaded scrolling.
This works around #116 for now without actually solving it completely.