Add exclusivity to prevent 12:00AM leaking into the next day event in the week

[geraldhoxha95]

Fixes #2617

By passing in a minute as unit, we can prevent an event that ends at exactly 12:00 AM from leaking into the next day, to more align with functionality from calendars like Outlook.

Screen.Recording.2024-07-13.at.8.54.36.AM-1.mov

[anjalikalsariya]

Hello folks,

Any one please review this PR. Actually I need this change in package for my current project.

Thanks

[cutterbl]

@geraldhoxha95 I need some example story and data (maybe in the Event Durations area of Storybook) where I can thoroughly test the assumption here. Code looks good, from what I can tell, but seeing is believing.

[geraldhoxha95]

@cutterbl Give me a few days, I will try to do it over the weekend.

[geraldhoxha95]

@cutterbl I added a few examples to the Event Durations.

[anjalininjadev]

Hi @cutterbl @geraldhoxha95

Is there any chance to merge and release this PR by the weekend? or Should wait for it for next week ?

Thanks

[geraldhoxha95]

@anjalininjadev I do not have the ability to merge this request.

[anjalikalsariya]

@anjalininjadev I do not have the ability to merge this request.

Okay @geraldhoxha95 , np.

@cutterbl Can you please take a look and merge it ? when you get a moment. We need this fix because we are going release first version of our product soon.

[cutterbl]

Looking over this code and seeing the changes you made with the moment localizer. What about the other localizers (Luxon, dayjs, etc)?

[geraldhoxha95]

I've been swamped this past month so haven't had a chance to get back to you. @anjalikalsariya @anjalininjadev if this issue is still relevant to you, or if @cutterbl if you think this a change worth making, I will try to do more testing sometime this week.

[cutterbl]

@geraldhoxha95 I still think it's worth exploring

[geraldhoxha95]

I will add more testing over the weekend

[geraldhoxha95]

@cutterbl I added tests for the other use cases.

[cutterbl]

@geraldhoxha95 Getting really close here. Added a few more code review notes.

[geraldhoxha95]

@cutterbl
Sorry, where can i find the code review notes?

[cutterbl]

@geraldhoxha95 Go to the Files Changed view and you'll see my last note there

[geraldhoxha95]

files_changed-2.mov

@cutterbl Am I missing something? I am not seeing anything on the Files Changed view

[cutterbl]

@geraldhoxha95 Realy? You should see a review on the dayjs.js localizer...

[anjalikalsariya]

Hi @cutterbl @geraldhoxha95

I think we are near to PR merge. My team are waiting for this fix release. I would like to request to you guys , Please try to merge this fix and new release as you can.

Thanks.
Anjali K

[cutterbl]

@geraldhoxha95 You should see something like the following screenshot. You'll also need to merge in latest changes from master and resolve conflicts as well.