fix: time grid header component margin is not recalculated when the s… #2411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…croll settings change on macos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #2402
Issue:
https://www.loom.com/share/428411cb7d0144aabe921946c311acd0
When the scroll settings is changed on macOS, the margin calculation for
TimeGridHeaderis not recalculated which create a misalignment between the header and the content of theTimeGrid.Solution:
Add an observer for the content, when the scroll bar is hidden/displayed we calculate the scroll bar width as a state in the
TimeGridcomponent and move it as a prop toTimeGridHeader.