Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion to evaluate click as a smallest selection #5

Closed
haaragh opened this issue Nov 4, 2015 · 1 comment
Closed

Suggestion to evaluate click as a smallest selection #5

haaragh opened this issue Nov 4, 2015 · 1 comment

Comments

@haaragh
Copy link

haaragh commented Nov 4, 2015

Hello! I am testing the calendar in own project.Thank you for your work.

In the week and day views while dragging the mouse we get a selected area which gives as slotInfo object, whereas mouse click does not do same thing. In case there was not prior selection dayslot does not hold slotInfo in its inner state. If there was a selection made, clicking will refer to that same selection's data as slotInfo (no matter where I click, obviously since in DaySlot state holds it, and click refers to this.state ).

...
selector
      .on('select', () => {
        this._selectSlot(this.state)
        this.setState({ selecting: false })
      })
...

It would be (imo) helpful to treat click as a smallest selection according to the slot where clicking was made, and like in selection set info to inner state.

@jquense
Copy link
Owner

jquense commented Nov 4, 2015

ya that seems like a weird bug, I'll see what I can do. thanks

bonongvodoi pushed a commit to htactive/react-ht-calendar that referenced this issue Jan 10, 2018
…vents

Fix: Pass 'isAllDay' prop to header event components
cutterbl added a commit that referenced this issue Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants