Adds module-info.java

jqno · Jan 9, 2025 · 2b43861 · 2b43861
1 parent 90021ff
commit 2b43861
Show file tree

Hide file tree

Showing 8 changed files with 25 additions and 5 deletions.
diff --git a/build/checkstyle-config.xml b/build/checkstyle-config.xml
@@ -7,6 +7,10 @@
     <property name="charset" value="UTF-8"/>
     <property name="severity" value="error"/>
 
+    <module name="BeforeExecutionExclusionFileFilter">
+        <property name="fileNamePattern" value="module\-info\.java$"/>
+    </module>
+
     <module name="FileLength"/>
     <module name="FileTabCharacter"/>
     <module name="NewlineAtEndOfFile">

diff --git a/equalsverifier-core/src/main/java/module-info.java b/equalsverifier-core/src/main/java/module-info.java
@@ -0,0 +1,17 @@
+module nl.jqno.equalsverifier {
+    exports nl.jqno.equalsverifier;
+    exports nl.jqno.equalsverifier.api;
+
+    // Direct dependencies
+    requires net.bytebuddy;
+    requires org.objenesis;
+
+    // Built-in prefab values
+    requires static com.google.common;
+    requires static java.desktop;
+    requires static java.naming;
+    requires static java.rmi;
+    requires static java.sql;
+    requires static javafx.base;
+    requires static org.joda.time;
+}
diff --git a/equalsverifier-release-main/pom.xml b/equalsverifier-release-main/pom.xml
@@ -61,7 +61,6 @@
                             <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
                         </manifest>
                         <manifestEntries>
-                            <Automatic-Module-Name>nl.jqno.equalsverifier</Automatic-Module-Name>
                             <Multi-Release>true</Multi-Release>
                             <Implementation-Title>EqualsVerifier</Implementation-Title>
                             <Website>${project.url}</Website>

diff --git a/equalsverifier-release-nodep/pom.xml b/equalsverifier-release-nodep/pom.xml
@@ -61,7 +61,6 @@
                             <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
                         </manifest>
                         <manifestEntries>
-                            <Automatic-Module-Name>nl.jqno.equalsverifier</Automatic-Module-Name>
                             <Multi-Release>true</Multi-Release>
                             <Implementation-Title>EqualsVerifier (no dependencies)</Implementation-Title>
                             <Website>${project.url}</Website>

diff --git a/...se-verify/src/test/java/nl/jqno/equalsverifier/verify_release/jar/MainJavadocJarTest.java b/...se-verify/src/test/java/nl/jqno/equalsverifier/verify_release/jar/MainJavadocJarTest.java
@@ -27,6 +27,6 @@ static void clean() throws Exception {
 
     @Test
     void presenceOfCoreSources() {
-        jar.assertPresenceOf("/index.html", EV + "/EqualsVerifier.html");
+        jar.assertPresenceOf("/index.html", "/nl.jqno.equalsverifier" + EV + "/EqualsVerifier.html");
     }
 }
diff --git a/...e-verify/src/test/java/nl/jqno/equalsverifier/verify_release/jar/NodepJavadocJarTest.java b/...e-verify/src/test/java/nl/jqno/equalsverifier/verify_release/jar/NodepJavadocJarTest.java
@@ -27,6 +27,6 @@ static void clean() throws Exception {
 
     @Test
     void presenceOfCoreSources() {
-        jar.assertPresenceOf("/index.html", EV + "/EqualsVerifier.html");
+        jar.assertPresenceOf("/index.html", "/nl.jqno.equalsverifier" + EV + "/EqualsVerifier.html");
     }
 }
diff --git a/...se-verify/src/test/java/nl/jqno/equalsverifier/verify_release/jar/helper/JarAsserter.java b/...se-verify/src/test/java/nl/jqno/equalsverifier/verify_release/jar/helper/JarAsserter.java
@@ -14,6 +14,7 @@ public JarAsserter(JarReader reader) {
 
     public void assertPresenceOfCoreClasses() {
         assertPresenceOf(
+            "/module-info.class",
             EV + "/EqualsVerifier.class",
             EV + "/internal/reflection/ClassProbe.class",
             EV + "/internal/checkers/HierarchyChecker.class");
@@ -51,7 +52,6 @@ public void assertContentOfManifest(String implementationTitle) {
         var manifest = new String(reader.getContentOf(filename));
         assertThat(manifest)
                 .satisfies(
-                    m -> assertContains("Automatic-Module-Name: nl.jqno.equalsverifier", m, filename),
                     m -> assertContains("Implementation-Title: " + implementationTitle, m, filename),
                     m -> assertContains("Implementation-Version: ", m, filename),
                     m -> assertContains("Multi-Release: true", m, filename),

diff --git a/pom.xml b/pom.xml
@@ -153,6 +153,7 @@
                 <version>${version.maven-surefire-plugin}</version>
                 <configuration>
                     <argLine>@{argline.full}</argLine>
+                    <useModulePath>false</useModulePath>
                     <trimStackTrace>false</trimStackTrace>
                     <useSystemClassLoader>false</useSystemClassLoader>
                 </configuration>