-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
builtin.jq: whilst #2776
Open
pkoppstein
wants to merge
1
commit into
jqlang:master
Choose a base branch
from
pkoppstein:whilst
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
builtin.jq: whilst #2776
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to define a code style for jq. I've become very happy with 4-space indentation except for 2 spaces for
|
, like this:I think until we decide on a style for jq code, maybe it'd be best to not restyle existing jq code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just trying to ensure while/whilst/until were consistently formatted, admittedly in the 2-space style -- two spaces saves space-time, no? I thought that was important for builtin.jq ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing style of surrounding code to be more consistent is something I like to do -though it can be irritating because it clutters diffs and complicates use of
git blame
-, but in this case I'm not sure what style we ought to adopt, and my own jq-coding style has change over time, so forsrc/builtin.jq
I would prefer we don't gratuitously re-style until we decide on a style. Conversely, I'm not asking you to adopt a style for jq code for now either -- if eventually we have to restyle all ofsrc/builtin.jq
, so be it.(For C code in jq the style is fairly consistent already, and very much in @stedolan's C style.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicowilliams - In case you haven't noticed, @itchyny's builtin.jq in gojq uses the two-space style :-)
https://github.com/itchyny/gojq/blob/main/builtin.jq
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pkoppstein no, I've not noticed. It's on my list to eventually go take a look at
fq
,jqjq
,gojq
,rq
, and others, but my time is limited. What they do for style is interesting, but what they do for semantics is much more interesting as we want jq-alikes to interoperate. As for style, like I said, my own jq style has evolved and I think we should discuss that separately and not gratuitously restylesrc/builtin.jq
for the time being even though I otherwise would prefer that we do restyle as we go.