Remove undefined behavior caught by LLVM 10 UBSAN. #2108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM 10's UBSAN catches several cases of undefined behavior when running the test suite:
jv_get
cast array indices to an int, even if the index is out of range. I added a bounds check.Additionally, I added
-fno-sanitize-recover=undefined
to the CFLAGS, which is necessary to make UBSAN actually crash the program (and therefore fail the tests) instead of just logging an error.