alloc: properly allocate memory handler per thread #2099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now the memory handler is allocated once, for the first thread that happens to call it. If pthread_getspecific is then called from another thread, the memory handler is not allocated (because pthread_once is only called for *all* threads, not per thread) and jq aborts because it thinks memory allocation failed. What we need to do instead is call pthread_key_create from the initializer, and then allocate a memory handler for every thread when it sees there's none yet. I also removed the atexit stuff, and instead use the destructor function you can pass into pthread_key_create.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the memory handler is allocated once, for the first thread
that happens to call it. If pthread_getspecific is then called from
another thread, the memory handler is not allocated (because
pthread_once is only called for all threads, not per thread) and jq
aborts because it thinks memory allocation failed.
What we need to do instead is call pthread_key_create from the
initializer, and then allocate a memory handler for every thread when it
sees there's none yet.
I also removed the atexit stuff, and instead use the destructor
function you can pass into pthread_key_create.
I figured this out by looking at this example: https://www.ibm.com/support/knowledgecenter/ssw_ibm_i_74/rzahw/rzahwe21rx.htm and the pthread docs