Added is{scalar,value,..}. Fixes leaf_paths bug. Leaf paths
#1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now paths to `false` leaves are correctly returned. Added the test new functions to the docs.
There are a few reasonable ways recurse could behave. The standard
libraries implemntation does the following:
`recurse(f;cond)` yields ., then . | f if . | f satisfies cond, then
. | f | f if . | f | f satisfies cond,
etc...
But it turns out that for paths, you want the following behavior:
`recurse(f;cond)` yields ., then . | f is . satisfies cond, then
. | f | f if . | f satisfies cond,
etc.
The difference is non-trivial (and there are actually a few degrees of
freedom here), so I gave paths its own definition, rather than adding a
new builtin. This means we don't have two builtin recurses floating
around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally PR #1178, but I needed to move this to its own branch, so I closed the old PR.