A1-polish: prerelease version parse + hung-server clean FAIL + drop unused import - #14
Merged
Conversation
…erver FAIL (TDD red)
Adds: _parse_version must read leading-digits-per-component so '3.4.0rc1'->[3,4,0]
not [3,4,1]; _mcp_session must catch subprocess.TimeoutExpired and return {} so a
hung server yields a clean FAIL report instead of crashing the gate; run_smoke
reports ok=False (not a crash) when the server hangs. Fail pre-fix.
…n FAIL, drop unused import (TDD green) Addresses coder-2's #11 cross-review notes (1-3): - remove the unused 'from .version import __version__' import. - _parse_version takes leading digits per component (pre-release suffix no longer misread as a higher patch). - _mcp_session catches subprocess.TimeoutExpired -> returns {} so a hung server produces a FAIL report, not a crash. (Note 4, initialize-handshake-skip, kept as intentional: mempalace doesn't gate tools/list on the initialized notification.) 22/22 tests pass; live gate still PASS on the qdrant backend; ruff clean.
Owner
Author
Architect review under /collaborate-to-build protocolSame-account constraint (GitHub blocks Verdict: APPROVE Reviewed all 3 fixes against the code + ran the suite (22/22 pass; TDD honest:
Note 4 (initialize-handshake-skip) correctly kept as intentional + documented — mempalace doesn't gate Scope clean (only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A1-polish — coder-2's #11 cross-review notes (1–3)
Optional wind-down follow-up to the merged A1 smoke-check. Addresses the three non-blocking notes from coder-2's PR #11 review; note 4 is kept as intentional.
from .version import __version__was unused (version comes from the server'sinitializeresponse, not the local constant)._mcp_sessionnow catchessubprocess.TimeoutExpiredand returns{}, so a hung/stuck server produces aSMOKE-CHECK: FAILreport (all checks "no response") instead of crashing the gate with a traceback. A gate that exists to detect a broken server must not itself crash on one._parse_versionnow takes leading digits per component, so"3.4.0rc1"→[3,4,0](satisfies the 3.4.0 floor as the base version) rather than the old bug where"0rc1"was read as patch1→[3,4,1].Kept as intentional (note 4): no
notifications/initializedis sent beforetools/list— mempalace'shandle_requestprocesses each method independently and does not gatetools/liston the initialized notification, so it's correct for this server.Verification
test_smoke_upgradepass; ruff clean.python -m mempalace.smoke_upgrade→ version/advertise/search/round-trip all PASS, exit 0).