Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crates and UI test #116

Merged
merged 5 commits into from
Jun 16, 2024
Merged

Update crates and UI test #116

merged 5 commits into from
Jun 16, 2024

Conversation

aumetra
Copy link
Contributor

@aumetra aumetra commented Jun 15, 2024

This PR just updates a few crates that were out of date.

List of out-of-date crates:

  • axum-test (dev dependency)
  • idna (actually used but not in the public interface)
  • owo-colors (dev dependency)

It also (begrudgingly) updates a UI test because the newest stable changes the order of the types yet again.


The idna update also uses the new domain_to_ascii_cow API, meaning no allocations if the domain is already in its ASCII representation.

It also uses the AsciiDenyList::URL as recomended by the idna docs. Not sure if this potentially breaks something for people? I guess this is a case of "test by scream", they'll complain if something breaks.

@aumetra
Copy link
Contributor Author

aumetra commented Jun 15, 2024

For real? axum-test v15 requires rustc v1.75?

@aumetra
Copy link
Contributor Author

aumetra commented Jun 15, 2024

Y'know, I know you said I can just update axum-test and just exclude it on the pinned version, but I feel my sanity slipping trying to figure out a way that my brain would be happy about.

So I think I'll leave it on v14 for now..

@jprochazk
Copy link
Owner

So I think I'll leave it on v14 for now..

Fair enough, thanks!

@jprochazk jprochazk merged commit 0c62b91 into jprochazk:main Jun 16, 2024
5 checks passed
@aumetra aumetra deleted the update-crates branch June 16, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants