Skip to content

Commit

Permalink
net/http: skip TestClientTimeout_Headers_h{1,2} on windows/arm and wi…
Browse files Browse the repository at this point in the history
…ndows/arm64

This extends the skip added in CL 375635 to the "_Headers" variant of
the test, since we have observed similar failures in that variant on
the builders.

For golang#43120

Change-Id: Ib1c97fbb776b576271629272f3194da77913a941
Reviewed-on: https://go-review.googlesource.com/c/go/+/379156
Trust: Bryan Mills <[email protected]>
Run-TryBot: Bryan Mills <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Damien Neil <[email protected]>
  • Loading branch information
Bryan C. Mills authored and jproberts committed Jun 21, 2022
1 parent 91c911c commit 4018efd
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/net/http/client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1339,6 +1339,9 @@ func testClientTimeout_Headers(t *testing.T, h2 bool) {
t.Error("net.Error.Timeout = false; want true")
}
if got := ne.Error(); !strings.Contains(got, "Client.Timeout exceeded") {
if runtime.GOOS == "windows" && strings.HasPrefix(runtime.GOARCH, "arm") {
testenv.SkipFlaky(t, 43120)
}
t.Errorf("error string = %q; missing timeout substring", got)
}
}
Expand Down

0 comments on commit 4018efd

Please sign in to comment.