Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn about OOM #124

Closed
wants to merge 1 commit into from
Closed

Warn about OOM #124

wants to merge 1 commit into from

Conversation

dandv
Copy link

@dandv dandv commented Oct 23, 2019

No description provided.

@RyanZim
Copy link
Collaborator

RyanZim commented Oct 23, 2019

Taking a quick look at json-write, it seems that it's a newline-delimited-JSON library, not a regular JSON library? Also, no updates for 4 years.

@dandv
Copy link
Author

dandv commented Oct 23, 2019

Yep, I had filed a FR to allow for output formatting.

@RyanZim
Copy link
Collaborator

RyanZim commented Oct 23, 2019

Yeah, we can't recommend a NDJSON library as a substitute for a normal JSON library. Normal JSON just isn't built for large datasets, that's all.

@RyanZim RyanZim closed this Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dandv @RyanZim