Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor test.js #375

Merged
merged 1 commit into from
Feb 28, 2017
Merged

Refactor test.js #375

merged 1 commit into from
Feb 28, 2017

Conversation

JPeer264
Copy link
Collaborator

I totally forgot one file to refactor 😅

.on('end', () => ...) can be written as one liner, but there is no real benefit, as it is harder to read.

Thanks again for this awesome library and that I could help you out 👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.434% when pulling 2c78eec on JPeer264:feature/refactor-es6 into 42656df on jprichardson:master.

@jprichardson jprichardson merged commit 3f34210 into jprichardson:master Feb 28, 2017
@jprichardson
Copy link
Owner

Thanks again @JPeer264!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manidlou manidlou manidlou approved these changes

@RyanZim RyanZim RyanZim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JPeer264 @coveralls @jprichardson @manidlou @RyanZim