Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure symlink & link #161

Closed
wants to merge 1 commit into from
Closed

ensure symlink & link #161

wants to merge 1 commit into from

Conversation

reggi
Copy link
Contributor

@reggi reggi commented Aug 4, 2015

No description provided.

@reggi
Copy link
Contributor Author

reggi commented Aug 4, 2015

What I'm getting from this is:

  1. path.isAbsolute isn't in older version of node, there's a fill sindresorhus/path-is-absolute
  2. Some of my tests expect paths in a posix specific format.

@jprichardson
Copy link
Owner

Fantastic work! It looks like you put a lot of time into this, thank you!

  1. I'm ok with including the polyfill path-is-absolute until we drop Node 0.10 support.
  2. Why the inclusion of chai? Why not just use basic assert?
  3. Would it be to much work to fix the POSIX specific paths? So that the tests pass on Windows?

@reggi reggi closed this Aug 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reggi @jprichardson