Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve file timestamp on copy. Closes #138 #139

Closed
wants to merge 1 commit into from
Closed

Preserve file timestamp on copy. Closes #138 #139

wants to merge 1 commit into from

Conversation

goloroden
Copy link

No description provided.

@goloroden goloroden changed the title Preserve file timestamp on copy. #138 Preserve file timestamp on copy. Closes #138 May 29, 2015
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 88.91% when pulling d40bdf9 on goloroden:master into a4dae1d on jprichardson:master.

@jprichardson
Copy link
Owner

This isn't going to work. It needs to be modified in a few ways:

  1. It should use async APIs.
  2. There should be an included test.
  3. What is the default behavior on Windows or Posix? There should be a flag added to control this behavior.

I really appreciate your interest and willingness to help. If you can't or don't want to make these modifications now, not a big deal. I will get to it eventually :)

@goloroden
Copy link
Author

Of course, you are right about this :-)

After a few hours of searching our actual problem, we did not think enough about how to do it properly. Sorry for that.

Unfortunately, to make it right, at least right now we do not have the time ... sorry :-(

@jprichardson
Copy link
Owner

Unfortunately, to make it right, at least right now we do not have the time ... sorry :-(

I figured, that's OK. I'll leave this PR open as a reminder for myself :)

@goloroden
Copy link
Author

This PR can then be closed, as it has been superseded by #141.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants