Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle EEXIST error when clobbering dir #134

Conversation

overlookmotel
Copy link
Contributor

Some versions of Linux (including on the Travis container infrastructure) throw an EEXIST error rather than ENOTEMPTY when you try to overwrite a directory while renaming, and that wasn't being handled.

This PR fixes that.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.87% when pulling 69b61b4 on overlookmotel:Handle-EEXIST-error-when-clobbering-dir into 2e9ac77 on jprichardson:master.

jprichardson added a commit that referenced this pull request May 8, 2015
…lobbering-dir

Handle EEXIST error when clobbering dir
@jprichardson jprichardson merged commit b291eee into jprichardson:master May 8, 2015
@jprichardson
Copy link
Owner

Thanks for this! Btw, which Node.js version and Linux version did you notice this behavior?

@overlookmotel overlookmotel deleted the Handle-EEXIST-error-when-clobbering-dir branch May 10, 2015 12:33
@overlookmotel
Copy link
Contributor Author

Thanks for merging. It was on Travis's container infrastructure. Reading Travis's output, seems that is Ubuntu 12.04.5 LTS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants