Skip to content

Change (some) callbacks to only trigger when complete. #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change (some) callbacks to only trigger when complete. #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 29 additions & 17 deletions cacheService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,11 +152,17 @@ function cacheService(cacheServiceConfig, cacheModules) {
expiration = null;
}
log(false, '.set() called:', {key: key, value: value});
var moduleCallbacks = 0;
for(var i = 0; i < self.cachesLength; i++){
var cache = self.caches[i];
var ref = (i === self.caches.length - 1) ? refresh : null;
var func = (i === 0) ? cb : noop;
cache.set(key, value, expiration, ref, func);
cache.set(key, value, expiration, ref, moduleCallback);
}
function moduleCallback(err){
if (++moduleCallbacks === self.cachesLength){
// note: no errors are passed back!
cb(null);
}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about this some more, it should probably just use async's map() to make the .set() calls on all of the modules and collect the results. This is exactly the kind of synchronization management for which async was designed.

}
};

Expand All @@ -174,14 +180,16 @@ function cacheService(cacheServiceConfig, cacheModules) {
var expiration = arguments[1] || null;
var cb = arguments[2] || null;
log(false, '.mset() called:', {data: obj});
var moduleCallbacks = 0;
for(var i = 0; i < self.cachesLength; i++){
var cache = self.caches[i];
expiration = expiration || cache.expiration;
if(i === self.caches.length - 1){
cache.mset(obj, expiration, cb);
}
else{
cache.mset(obj, expiration);
cache.mset(obj, expiration, moduleCallback);
}
function moduleCallback(err){
if (++moduleCallbacks === self.cachesLength){
// note: no errors are passed back!
cb(null);
}
}
};
Expand All @@ -196,13 +204,15 @@ function cacheService(cacheServiceConfig, cacheModules) {
throw new Exception('INCORRECT_ARGUMENT_EXCEPTION', '.del() requires a minimum of 1 argument.');
}
log(false, '.del() called:', {keys: keys});
var moduleCallbacks = 0;
for(var i = 0; i < self.cachesLength; i++){
var cache = self.caches[i];
if(i === self.caches.length - 1){
cache.del(keys, cb);
}
else{
cache.del(keys);
cache.del(keys, moduleCallback);
}
function moduleCallback(err){
if (++moduleCallbacks === self.cachesLength){
// note: no errors are passed back!
cb(null);
}
}
};
Expand All @@ -213,13 +223,15 @@ function cacheService(cacheServiceConfig, cacheModules) {
*/
self.flush = function(cb){
log(false, '.flush() called');
var moduleCallbacks = 0;
for(var i = 0; i < self.cachesLength; i++){
var cache = self.caches[i];
if(i === self.caches.length - 1){
cache.flush(cb);
}
else{
cache.flush();
cache.flush(moduleCallback);
}
function moduleCallback(err){
if (++moduleCallbacks === self.cachesLength){
// note: no errors are passed back!
cb(null);
}
}
};
Expand Down