Skip to content

[BREAKING/v3] Drop node 12 support and run tests against minimum supported versions. #1599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LukeSheard merged 2 commits into from
Apr 28, 2022
Merged

[BREAKING/v3] Drop node 12 support and run tests against minimum supported versions. #1599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ec380b
Drop node 12 support and run tests against minimum supported versions.
LukeSheard Apr 20, 2022
aee9d63
Merge branch 'main' into feature/drop-node-12
LukeSheard Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/wild-kings-invent.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'create-modular-react-app': major
'modular-scripts': major
---

Drop support for node 12 in favor of LTS versions `^14.17.0 || >=16.0.0`.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v3.1.1
with:
node-version: 14.x
node-version: '14.17.0'
registry-url: https://registry.npmjs.org/
cache: 'yarn'

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/static.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v3.1.1
with:
node-version: 14.x
node-version: '14.17.0'
cache: 'yarn'

- name: 'Install Dependencies'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest]
node-version: [12.x, 14.x, 16.x]
node-version: ['14.17.0', '16.0.0']

steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion babel.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ module.exports = (api) => {
{
targets: {
// TODO: can we get this to read from package.json somehow..?
node: '12',
node: '14',
},
},
],
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"packages/**"
],
"engines": {
"node": "^12.13.0 || ^14.15.0 || >=15.0.0"
"node": "^14.17.0 || >=16.0.0"
},
"scripts": {
"format": "prettier --write .",
Expand Down
2 changes: 1 addition & 1 deletion packages/create-modular-react-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"./package.json": "./package.json"
},
"engines": {
"node": "^12.13.0 || ^14.15.0 || >=15.0.0"
"node": "^14.17.0 || >=16.0.0"
},
"scripts": {
"create-modular-react-app": "ts-node src/cli.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/modular-scripts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"./tsconfig.json": "./tsconfig.json"
},
"engines": {
"node": "^12.13.0 || ^14.15.0 || >=15.0.0"
"node": "^14.17.0 || >=16.0.0"
},
"scripts": {
"modular": "ts-node src/cli.ts",
Expand Down