Skip to content

Version Packages#1553

Closed
github-actions[bot] wants to merge 1 commit intorelease/v4from
changeset-release/release/v4
Closed

Version Packages#1553
github-actions[bot] wants to merge 1 commit intorelease/v4from
changeset-release/release/v4

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Apr 7, 2022

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to release/v4, this PR will be updated.

Releases

modular-scripts@3.0.0

Major Changes

Patch Changes

create-modular-react-app@2.1.5

Patch Changes

@LukeSheard
Copy link
Contributor

@cristiano-belloni something is wrong with the release branches as this is triggering a normal release of modular. Looks like there should be a check that release/** branches are in pre-release mode, the opposite to main release flow.

@LukeSheard LukeSheard closed this Apr 7, 2022
@LukeSheard LukeSheard deleted the changeset-release/release/v4 branch April 7, 2022 13:25
@cristiano-belloni
Copy link
Contributor

@cristiano-belloni something is wrong with the release branches as this is triggering a normal release of modular. Looks like there should be a check that release/** branches are in pre-release mode, the opposite to main release flow.

Even if you open a pre-release in this branch now, you will get the wrong version, no matter if you branch off main or release-webpack-5 (in both cases I think you'll get a 3.0 based alpha, which is wrong). I should probably have parked this in a feature/ branch and kept it in sync with main till after the release of 3.0, at which point I could have created the release branch.
Anyway, we don't normally want to have two pre-releases around at the same time - this is a special occasion due to two breaking changes being queued to be released (and tested) one after the other. We can ignore this changeset until it's time to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants