Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
110 commits
Select commit Hold shift + click to select a range
76372f3
Views use the webpack configuration
Jan 28, 2022
0b2f6f6
Use esm plugin for Webpack
Jan 28, 2022
670cdcd
Don't generate a runtime chunk if view
Jan 31, 2022
2470781
Always use the same name for the main chunk
Jan 31, 2022
82e959b
memoize get dependencies
Jan 31, 2022
fa31dd3
Build 3rd party dependencies as external by default
Jan 31, 2022
96ef909
Add esbuild support for apps, use correct bundled dependencies
Feb 1, 2022
1b15c97
Correctly check required files for apps
Feb 2, 2022
765d346
Don't die on parsing if externals are not specified
Feb 3, 2022
aba5fe7
Fix webpack app build, app start and view start
Feb 3, 2022
6865b30
Remove console.log
Feb 3, 2022
131afbe
Add extension resolvers
Feb 3, 2022
58b093d
Resolve all externsions if we're not in an app
Feb 3, 2022
04f3b93
Consider views typescript packages even if they don't have a tsconfig
Feb 4, 2022
8b6396d
Revert "Consider views typescript packages even if they don't have a …
Feb 4, 2022
90117f1
Use name main.js
Feb 4, 2022
52f2a93
Bundle all dependencies by default
Feb 7, 2022
cd1400c
Build trampoline to load generated view
Feb 7, 2022
beb8e66
Revert to hashed files
Feb 7, 2022
6f62e98
Add rewriting plugin for esbuild
Feb 8, 2022
40eb556
Revert webpack, concentrate on esbuild
Feb 8, 2022
8699d31
Remove esm plugin
Feb 8, 2022
dc5c751
Use external templates and blocklists
Feb 8, 2022
ce19a83
Rename deny -> block
Feb 8, 2022
6e68f63
cleanup
Feb 8, 2022
1915a07
Merge remote-tracking branch 'origin/main' into feature/module-rewrite
Feb 9, 2022
ac66bb9
Use esbuild + plugin to build views when starting apps
Feb 9, 2022
e48bd93
move trampoline into es scripts
Feb 10, 2022
922afb2
Trampoline is created in-memory
Feb 10, 2022
48c94cf
Serve trampoline
Feb 10, 2022
12eb628
Merge remote-tracking branch 'origin/main' into feature/module-rewrite
Feb 10, 2022
e431e74
serve trampoline with the right content-type
Feb 10, 2022
127b6ba
Modify serve to include views
Feb 10, 2022
55e2923
use createIndex to build index file for views
Feb 10, 2022
f2dcab4
parse dependencies better
Feb 11, 2022
67dea20
Support submodules
Feb 11, 2022
6f2a63c
Use import map instead of dependencies
Feb 11, 2022
f12f817
Remove unneeded check
Feb 11, 2022
a6834f1
Revert to earlier patch of react-overlay
Feb 11, 2022
e62df3e
Fix reloading
Feb 11, 2022
c0c99ef
Fix react overlay
Feb 14, 2022
47d8d9c
Remove tsconfig
Feb 14, 2022
bf09cd3
Externalise dependency filtering
Feb 14, 2022
7add32f
include module entry point in manifest
Feb 14, 2022
fa4e5fa
Actually write bundled dependencies in manifest
Feb 14, 2022
2457caa
Merge branch 'main' into feature/module-rewrite
cristiano-belloni Feb 14, 2022
ce87a9f
Fix view tests - bare minumum
Feb 14, 2022
d46627f
Fix view tests port
Feb 14, 2022
b04ed3c
Split tests into index and view
Feb 15, 2022
4ad02a9
First test with external view
Feb 15, 2022
6860013
Re-add tests in main directory
Feb 15, 2022
4eac9c0
Merge branch 'main' into feature/module-rewrite
cristiano-belloni Feb 15, 2022
4bb5497
Merge remote-tracking branch 'origin/main' into feature/module-rewrite
Feb 15, 2022
e94ea9f
Fix socket messaging
Feb 15, 2022
82d9eed
Merge branch 'feature/module-rewrite' of https://github.com/jpmorganc…
Feb 15, 2022
a13a0d9
Remove kill function
Feb 16, 2022
c82d8ec
Replace kill function, change order of tests
Feb 16, 2022
9a21cfe
Add logs to debug CI
Feb 16, 2022
25139e6
Add logs to open browser for CI
Feb 16, 2022
2ac801d
Add better logs to open browser for CI
Feb 16, 2022
e234b15
Add even better logs to open browser for CI
Feb 16, 2022
06d50e9
stringify logs
Feb 16, 2022
c2034eb
provide correct null value for DEFAULT_BROWSER
Feb 16, 2022
d2a01b7
kill -9 hanging servers
Feb 16, 2022
802c8c7
Clean up debug info
Feb 16, 2022
1388678
Merge tests into index
Feb 16, 2022
ce423be
Merge branch 'main' into feature/module-rewrite
cristiano-belloni Feb 16, 2022
d572c82
Port is back to 4000
cristiano-belloni Feb 16, 2022
f2d15e7
memoize get dependencies
Jan 31, 2022
b75f563
Revert to earlier patch of react-overlay
Feb 11, 2022
c301a1b
Fix esbuild reload
Feb 16, 2022
d078d7a
Remove tsconfig
Feb 16, 2022
205a812
Fix wsReload
Feb 16, 2022
2e51590
Terminate server
Feb 16, 2022
85c634a
Better result
cristiano-belloni Feb 16, 2022
1b7f03d
Better order
cristiano-belloni Feb 16, 2022
a951f45
Fix react overlay
Feb 14, 2022
1ee64a4
Merge branch 'feature/various-fixes' of https://github.com/jpmorganch…
Feb 16, 2022
1e15a3a
Don't change the flag before it's due when reloading
Feb 16, 2022
9c1b208
Close server by closing connections one by one
Feb 16, 2022
30f6868
revert memoizing gpd; not needed
Feb 16, 2022
3d1e404
Merge branch 'feature/various-fixes' into feature/module-rewrite
Feb 16, 2022
dd3d928
Merge remote-tracking branch 'origin/main' into feature/module-rewrite
Feb 17, 2022
33b63f2
Revert memoizing gpd
Feb 17, 2022
48132ee
Add tests for custom CDN
Feb 17, 2022
57c2416
Merge branch 'main' into feature/module-rewrite
cristiano-belloni Feb 17, 2022
6510cff
Merge branch 'feature/module-rewrite' of https://github.com/jpmorganc…
Feb 17, 2022
c99c798
Add esm specific tests
Feb 17, 2022
d7de993
Merge branch 'main' into feature/module-rewrite
cristiano-belloni Feb 18, 2022
052ce3a
Merge branch 'main' into feature/module-rewrite
cristiano-belloni Feb 18, 2022
caa7b66
Runtime correct order
Feb 18, 2022
806997f
Better definition of default value
Feb 18, 2022
a4fcdd1
Better definition of RequestHandler
Feb 18, 2022
8b9f0a1
Explicitly need esbuild
Feb 21, 2022
64aae60
Change tests to correctly use esbuild when building views
Feb 21, 2022
3f45481
Merge branch 'main' into feature/module-rewrite
cristiano-belloni Feb 28, 2022
8e6e136
Fix dependency scope in rewrite plugin
Mar 3, 2022
9ad46d8
Rewrite global css
Mar 3, 2022
4fd64be
Clear css map on start, to fix incremental mode
Mar 3, 2022
02e29b8
Merge remote-tracking branch 'origin/main' into feature/module-rewrite
Mar 4, 2022
1063e7c
If target is esnext, use CSS module scripts
Mar 4, 2022
f455cd6
Merge remote-tracking branch 'origin/main' into feature/module-rewrite
Mar 7, 2022
b4b8b47
Merge branch 'main' into feature/module-rewrite
cristiano-belloni Mar 10, 2022
36eda8e
Merge branch 'main' into feature/module-rewrite
cristiano-belloni Mar 11, 2022
3e88ffb
Merge remote-tracking branch 'origin/main' into feature/module-rewrite
Mar 11, 2022
36a351c
Merge remote-tracking branch 'origin/main' into feature/module-rewrite
Mar 17, 2022
e6d406d
Merge remote-tracking branch 'origin/main' into feature/module-rewrite
Mar 22, 2022
5fb4344
Merge remote-tracking branch 'origin/main' into feature/module-rewrite
Mar 25, 2022
b6d8882
Merge remote-tracking branch 'origin/main' into feature/module-rewrite
Mar 31, 2022
78bc31e
update snapshots
Mar 31, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/modular-scripts/src/__tests__/TestViewPackages.test-tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import * as React from 'react';
import get from 'lodash/get';
import merge from 'lodash.merge';
import { difference } from 'lodash';

export default function SampleView(): JSX.Element {
return (
<div>
<pre>{JSON.stringify({ get, merge, difference })}</pre>
</div>
);
}

This file was deleted.

12 changes: 6 additions & 6 deletions packages/modular-scripts/src/__tests__/build.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,14 @@ describe('WHEN building with preserve modules', () => {
├─ README.md #1jv3l2q
├─ dist-cjs
│ ├─ index.js #y5z0kw
│ ├─ index.js.map #1ppp712
│ ├─ index.js.map #16xad8o
│ ├─ runAsync.js #kr3qrh
│ └─ runAsync.js.map #18daxam
│ └─ runAsync.js.map #130u3kt
├─ dist-es
│ ├─ index.js #7arwpf
│ ├─ index.js.map #1in842g
│ ├─ index.js.map #n6rb69
│ ├─ runAsync.js #1tt0e7o
│ └─ runAsync.js.map #1qvfs9
│ └─ runAsync.js.map #r9z8sx
├─ dist-types
│ ├─ index.d.ts #12l2tmi
│ └─ runAsync.d.ts #1iek7az
Expand Down Expand Up @@ -149,10 +149,10 @@ describe('WHEN building packages with private cross-package dependencies', () =>
├─ README.md #1jv3l2q
├─ dist-cjs
│ ├─ index.js #1gj4b9h
│ └─ index.js.map #39c8bu
│ └─ index.js.map #1j96nz6
├─ dist-es
│ ├─ index.js #xezjee
│ └─ index.js.map #89b1k5
│ └─ index.js.map #12d2mbd
├─ dist-types
│ └─ index.d.ts #6hjmh9
└─ package.json"
Expand Down
Loading