Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/match-highlighting-problem #982

Merged
merged 2 commits into from
Mar 20, 2023

Conversation

cyfml
Copy link
Contributor

@cyfml cyfml commented Mar 16, 2023

I fixed this problem. Now match highlighting is correct. The reason is, the file path should also be converted into ID. But i find another problem. The size of row is not adaptive. But for other example, it works. It needs investigation. I am busy right now, so if i have free time, i will take a look at it.

NOT ADAPTIVE: image

ADAPTIVE: image

@tsaglam tsaglam added bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change labels Mar 16, 2023
@tsaglam tsaglam requested a review from sebinside March 16, 2023 16:30
@Medo3G
Copy link

Medo3G commented Mar 20, 2023

I fixed this problem. Now match highlighting is correct. The reason is, the file path should also be converted into ID. But i find another problem. The size of row is not adaptive. But for other example, it works. It needs investigation. I am busy right now, so if i have free time, i will take a look at it.

NOT ADAPTIVE: image

ADAPTIVE: image

This can be fixed by simply adding overflow-wrap: break-word; to

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@tsaglam tsaglam merged commit 258fd7a into jplag:develop Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants