Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance/page cannot be reloaded after refreshing #951

Conversation

cyfml
Copy link
Contributor

@cyfml cyfml commented Feb 27, 2023

This PR creates a 404 html, because SPA change pages by JS and it has only one page(index.html). All other urls are not accessed through github-pages, because it doesn't exist. So this 404 page will redirect to public path.

Copy link
Member

@sebinside sebinside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use relative redirection as an absolute path will break the dev version of Jplag deployed at https://jplag.github.io/JPlag-Dev/

@sebinside sebinside added bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies labels Feb 27, 2023
@cyfml
Copy link
Contributor Author

cyfml commented Feb 27, 2023

Please userelative redirection as an absolute path will break the dev version of Jplag deployed at https://jplag.github.io/JPlag-Dev/

@sebinside I try to redirect to index.html directly, but "index.html" will be in the URL and nothing will be shown. Let me try to find anthor way.

@cyfml
Copy link
Contributor Author

cyfml commented Feb 27, 2023

@sebinside Now, i change it in relative path.

@sebinside
Copy link
Member

I tested this solution with your deployment at https://cyfml.github.io/JPlag/. While is worked well for reloading on the overview page, it infinitely redirects when reloading a comparison page

@cyfml
Copy link
Contributor Author

cyfml commented Feb 28, 2023

I tested this solution with your deployment at https://cyfml.github.io/JPlag/. While is worked well for reloading on the overview page, it infinitely redirects when reloading a comparison page

@sebinside Relative path can not work. Because we have two urls, so i decide to use scripts to generate url dynamically. You can test it under https://cyfml.github.io/JPlag/ again.

@cyfml cyfml requested a review from sebinside February 28, 2023 11:23
@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

74.5% 74.5% Coverage
0.0% 0.0% Duplication

@sebinside sebinside merged commit 64bbded into jplag:develop Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants