-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance/page cannot be reloaded after refreshing #951
Enhance/page cannot be reloaded after refreshing #951
Conversation
…not-be-reloaded-after-refreshing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use relative redirection as an absolute path will break the dev version of Jplag deployed at https://jplag.github.io/JPlag-Dev/
@sebinside I try to redirect to index.html directly, but "index.html" will be in the URL and nothing will be shown. Let me try to find anthor way. |
@sebinside Now, i change it in relative path. |
I tested this solution with your deployment at https://cyfml.github.io/JPlag/. While is worked well for reloading on the overview page, it infinitely redirects when reloading a comparison page |
@sebinside Relative path can not work. Because we have two urls, so i decide to use scripts to generate url dynamically. You can test it under https://cyfml.github.io/JPlag/ again. |
Kudos, SonarCloud Quality Gate passed! |
This PR creates a 404 html, because SPA change pages by JS and it has only one page(index.html). All other urls are not accessed through github-pages, because it doesn't exist. So this 404 page will redirect to public path.