Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance/color #900

Merged
merged 5 commits into from
Feb 13, 2023
Merged

Enhance/color #900

merged 5 commits into from
Feb 13, 2023

Conversation

cyfml
Copy link
Contributor

@cyfml cyfml commented Jan 27, 2023

This PR changed the color scheme of matches. Some colors (Red and Green) which have implicit semantics are removed.

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies labels Jan 27, 2023
sebinside
sebinside requested changes Feb 9, 2023
View reviewed changes
Copy link
Member

@sebinside sebinside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While your approach does the job, nearly 50% of the code is duplicated (for the two intervals). Please define a method that gives you, e.g., an array of n colors of an interval [x,y] and call it twice, for each hue interval.

@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sebinside sebinside merged commit 54a4122 into jplag:develop Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebinside sebinside Awaiting requested review from sebinside

Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cyfml @sebinside @tsaglam