Enhance/warning if some comparisions missing #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if-some-comparisions-missing
…if-some-comparisions-missing
tsaglam
added
enhancement
tsaglam
added
report-viewer
tsaglam
reviewed
Jan 27, 2023
core/src/main/java/de/jplag/reporting/jsonfactory/ComparisonReportWriter.java
Outdated
Show resolved
Hide resolved
core/src/main/java/de/jplag/reporting/reportobject/ReportObjectFactory.java
Outdated
Show resolved
Hide resolved
…if-some-comparisions-missing
…if-some-comparisions-missing
…instead of three variables)
|
Kudos, SonarCloud Quality Gate passed! |
sebinside
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on last unmerged PR (Version check) and fixed problem: Show a warning if some/all comparison files are missing, in the console log and also in the report viewer when scrolling down, e.g., because there are 1000 comparisons but only 100 are included in the resulting zip file.
Trigger condition: If number of missing comparisons is 0, the warining will not be shown in the report-viewer. Otherwise, it will.
Addationaly, i keep the layout of
FileUploadViewas before, because PR#918 change the layout.