Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change documentation of language usage to constructor invocation #890

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

SirYwell
Copy link
Contributor

The documentation of how to use a specific language module seems to be outdated. LanguageOption does not exist anymore, and the JPlagOptions has a language component instead.

I updated all readmes from language modules. LanguageOption also seems to be referenced in the readme in endtoend-testing, however I don't know what the exact replacement would be there, so I left that out.

I'm not sure if you want this to target develop or main, so let me know if you want me to change it.

@sonarcloud
Copy link

sonarcloud bot commented Jan 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for noticing! Great PR!

@tsaglam tsaglam added bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change language PR / Issue deals (partly) with new and/or existing languages for JPlag labels Jan 25, 2023
@tsaglam tsaglam merged commit 7142bfd into jplag:develop Jan 25, 2023
@SirYwell SirYwell deleted the fix/readme-usage-lm branch January 25, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue/PR that involves a bug language PR / Issue deals (partly) with new and/or existing languages for JPlag minor Minor issue/feature/contribution/change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants