Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance/version check #878

Merged
merged 10 commits into from
Feb 13, 2023
Merged

Enhance/version check #878

merged 10 commits into from
Feb 13, 2023

Conversation

cyfml
Copy link
Contributor

@cyfml cyfml commented Jan 16, 2023

This PR enhances the version check and display more than a console warning, also a prompt displaying the warning when the situation is using development versions (0.0.0) or version mismatches . And Report-viewer loads the version from a JSON file.

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies labels Jan 16, 2023
Copy link
Member

@sebinside sebinside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some minor review comments.

report-viewer/src/model/factories/OverviewFactory.ts Outdated Show resolved Hide resolved
report-viewer/src/typings.d.ts Outdated Show resolved Hide resolved
report-viewer/src/version.json Show resolved Hide resolved
@sebinside sebinside self-requested a review February 9, 2023 08:12
@sonarcloud
Copy link

sonarcloud bot commented Feb 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sebinside sebinside merged commit 04a5df4 into jplag:develop Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants