Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance/codes selection #877

Merged
merged 10 commits into from
Jan 16, 2023
Merged

Conversation

cyfml
Copy link
Contributor

@cyfml cyfml commented Jan 12, 2023

This PR is based on last PR. It enables that codes can be selected and copied. And mouse icon is changed to grab-hand, when mouse is hover on file header.

@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies labels Jan 13, 2023
@tsaglam tsaglam removed their request for review January 13, 2023 09:59
@sebinside
Copy link
Member

@cyfml This is also fine. Please clean the history so that we can also merge this PR.

@cyfml
Copy link
Contributor Author

cyfml commented Jan 16, 2023

@sebinside I have cleaned the history, but PR has a problem. Can you take a look?

@tsaglam
Copy link
Member

tsaglam commented Jan 16, 2023

@sebinside I have cleaned the history, but PR has a problem. Can you take a look?

Did you merge the develop branch into your PR branch?

@cyfml
Copy link
Contributor Author

cyfml commented Jan 16, 2023

@sebinside I have cleaned the history, but PR has a problem. Can you take a look?

Did you merge the develop branch into your PR branch?

Yes. Merged.

@cyfml
Copy link
Contributor Author

cyfml commented Jan 16, 2023

You can check the last commit.

@sebinside
Copy link
Member

@cyfml What do you mean with PR has a problem?

@cyfml
Copy link
Contributor Author

cyfml commented Jan 16, 2023

@sebinside It seems build failed in Actions.

Error: Failed to execute goal org.sonarsource.scanner.maven:sonar-maven-plugin:3.9.1.2184:sonar (default-cli) on project aggregator: Parameter 'sonar.pullrequest.key' is mandatory for a pull request analysis -> [Help 1]
Error:
Error: To see the full stack trace of the errors, re-run Maven with the -e switch.
Error: Re-run Maven using the -X switch to enable full debug logging.
Error:
Error: For more information about the errors and possible solutions, please read the following articles:
Error: [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
Error: Process completed with exit code 1.

@sebinside sebinside merged commit 0252b4d into jplag:develop Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants