-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prototype for EMF model instance language module #856
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsaglam
added
the
language
PR / Issue deals (partly) with new and/or existing languages for JPlag
label
Dec 20, 2022
For some reason, the coverage calculation is off, even though the test case is executed. |
tsaglam
added
enhancement
Issue/PR that involves features, improvements and other changes
major
Major issue/feature/contribution/change
labels
Jan 12, 2023
JanWittler
reviewed
Jan 12, 2023
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
…based on different token sets.
…or path, even if they are not equal.
Internal MM language module improvement draft
# Conflicts: # language-api/src/main/java/de/jplag/Token.java
Kudos, SonarCloud Quality Gate passed! |
Open issues are documented in #576. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Issue/PR that involves features, improvements and other changes
language
PR / Issue deals (partly) with new and/or existing languages for JPlag
major
Major issue/feature/contribution/change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a language module for parsing EMF models (as in instances of EMF metamodels). In this prototypic implementation, the metamodel (Ecore file) needs to be provided as a submission to parse the metamodel itself. Tokens are extracted dynamically, meaning for every metaclass in the metamodel. This means the token set is very generic and not tailored according to specific kinds of models. As for visualization, Emfatic (which is used for metamodels) does not support models; we thus use a simplified textual tree view.
Additionally, this PR now adds the token normalization mechanism.
Tasks:
Additionally, with #1053 this PR now includes the newly added model normalization.