-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NPE when calling ParsingException constructors with null reason #839
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your branch is based on main but should be based on develop.
From my understanding of the comment in the pull request template https://github.com/jplag/JPlag/blob/main/.github/pull_request_template.md?plain=1#L3 together with semver (https://semver.org/#summary)
I thought main would be the appropriate branch. I can change the branch, but I think the template is confusing then. |
That's true, but your PR was targeting the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one smaller comment, besides that looks fine
I would still merge it into develop, as I am probably not releasing a patch version for this alone (I changed the target initially to develop). |
4146c7d
to
6d84f20
Compare
I changed the target branch and rebased the commit onto develop. |
Kudos, SonarCloud Quality Gate passed! |
A per the Javadocs,
null
values are permitted for thereason
, however passingnull
or using a constructor that doesn't take aString
causes a NullPointerException.I addressed this issue and created a regression test for it.
Note:
String#isBlank
returns true if the string is empty, so this check wasn't needed.