Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve EMF metamodel language modules #819

Merged
merged 24 commits into from
Dec 19, 2022
Merged

Improve EMF metamodel language modules #819

merged 24 commits into from
Dec 19, 2022

Conversation

tsaglam
Copy link
Member

@tsaglam tsaglam commented Nov 29, 2022 •
edited
Loading

Quality of life improvements for the EMF language modules:

  • Now also extract end tokens for the handcrafted module, specifically for containment relations
  • Uses Emfatic as a textual model view in the report viewer for both the dynamic and the handcrafted module
  • Expands the metamodel test cases

After this PR:

grafik

Before this PR:

grafik

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes major Major issue/feature/contribution/change language PR / Issue deals (partly) with new and/or existing languages for JPlag labels Nov 29, 2022
@tsaglam tsaglam requested a review from a team December 6, 2022 12:49
@tsaglam tsaglam marked this pull request as ready for review December 6, 2022 12:58
JanWittler
JanWittler approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@JanWittler JanWittler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments to reduce code complexity. Besides that, looks fine.

languages/emf-metamodel/src/main/java/de/jplag/emf/util/EmfaticModelView.java Show resolved Hide resolved
languages/emf-metamodel/src/main/java/de/jplag/emf/util/EmfaticModelView.java Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Dec 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.5% 85.5% Coverage
0.0% 0.0% Duplication

@tsaglam tsaglam merged commit ac3b7db into develop Dec 19, 2022
@tsaglam tsaglam deleted the emf-improvements branch December 19, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanWittler JanWittler JanWittler approved these changes

Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes language PR / Issue deals (partly) with new and/or existing languages for JPlag major Major issue/feature/contribution/change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsaglam @JanWittler