Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make language identifiers private #763

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Make language identifiers private #763

merged 1 commit into from
Nov 7, 2022

Conversation

JanWittler
Copy link
Contributor

@JanWittler JanWittler commented Oct 28, 2022 •
edited
Loading

Alternative solution to #713 (which was solved by #761) which makes all language identifiers private.

@JanWittler JanWittler marked this pull request as ready for review November 7, 2022 14:45
@sonarcloud
Copy link

sonarcloud bot commented Nov 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@tsaglam tsaglam merged commit 4a60a5e into develop Nov 7, 2022
@tsaglam tsaglam deleted the private-language-identifier branch November 7, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfuchss dfuchss dfuchss approved these changes

@tsaglam tsaglam tsaglam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JanWittler @tsaglam @dfuchss