Add R language frontend #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsaglam
added
enhancement
tsaglam
requested changes
Jun 20, 2022
tsaglam
approved these changes
Jun 21, 2022
dfuchss
requested changes
Jun 23, 2022
nestabentum
reviewed
Jun 23, 2022
jplag.frontend.R/src/main/java/de/jplag/R/RCombinedBaseListener.java
Outdated
Show resolved
Hide resolved
dfuchss
reviewed
Jun 23, 2022
Should the language option for the CLI also be adapted? |
Yes, I would say so. |
tsaglam
approved these changes
Jun 25, 2022
dfuchss
approved these changes
Jun 27, 2022
Closed
|
As it turns out, the "renaming R to rlang" left some inconsistencies, which is just terrible. Can the R branch be merged again from this PR, or do I need to open a new one? |
just open a new PR from that branch with a short description of what went wrong and how you fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a newly added frontend for the R language, complete with some tests and a brief README. Other submodules have only been altered to the extent necessary to make the R frontend usable.
Addressing issues #345, #451
EDIT: Also makes
LanguageOption.fromDisplayName()case insensitive for improved usability of the CLI interface.