Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store basecode comparisons in each submission instead in the comparison strategy #235

Merged

Conversation

dogayalcin
Copy link
Contributor

The submissions store their basecode matches internally.
closes #216

@tsaglam
Copy link
Member

tsaglam commented Nov 24, 2021

Thanks for your contribution and welcome to the project! Due to #234 your PR currently has some conflicts with the master branch.
I recommend solving the conflicts first, then I can review your changes.

Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a minor name issue that already persisted in the original code.

jplag/src/main/java/de/jplag/Submission.java Outdated Show resolved Hide resolved
jplag/src/main/java/de/jplag/Submission.java Outdated Show resolved Hide resolved
jplag/src/main/java/de/jplag/Submission.java Outdated Show resolved Hide resolved
@tsaglam tsaglam changed the title each_submission_store_its_own_matches Store basecode comparisons in each submission instead in the comparison strategy Nov 24, 2021
@tsaglam tsaglam merged commit e17dac4 into jplag:master Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basecode matches should be stored by each submission
2 participants