Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/record builders #1828

Merged
merged 5 commits into from
Jul 15, 2024
Merged

Feature/record builders #1828

merged 5 commits into from
Jul 15, 2024

Conversation

TwoOfTwelve
Copy link
Contributor

Added auto generated "with" methods to JPlagOptions, to reduce the amount of boilerplate code.

dfuchss
dfuchss reviewed Jun 27, 2024
View reviewed changes
@TwoOfTwelve TwoOfTwelve marked this pull request as draft June 27, 2024 11:36
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 4, 2024

Quality Gate Passed Quality Gate passed for 'JPlag Plagiarism Detector'

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change labels Jul 8, 2024
@TwoOfTwelve TwoOfTwelve marked this pull request as ready for review July 11, 2024 11:40
dfuchss
dfuchss approved these changes Jul 14, 2024
View reviewed changes
Copy link
Member

@dfuchss dfuchss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the last comment; if positive , I've approved :)

@tsaglam tsaglam merged commit 0d1c48e into develop Jul 15, 2024
44 checks passed
@tsaglam tsaglam deleted the feature/recordBuilders branch July 15, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsaglam tsaglam tsaglam approved these changes

@dfuchss dfuchss dfuchss approved these changes

Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TwoOfTwelve @tsaglam @dfuchss