Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up logger #1826

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Clean up logger #1826

merged 2 commits into from
Jun 25, 2024

Conversation

tsaglam
Copy link
Member

@tsaglam tsaglam commented Jun 24, 2024 •
edited
Loading

  • Merge logger classes
  • Minor code improvements
  • Update JDoc

Note: Members are reordered in a dedicated commit for readability.

@tsaglam tsaglam changed the base branch from main to develop June 24, 2024 14:12
@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change labels Jun 24, 2024
@sonarqubecloud SonarQubeCloud

This comment was marked as outdated.

Sign in to view
@tsaglam tsaglam marked this pull request as ready for review June 25, 2024 07:56
@tsaglam tsaglam requested a review from a team June 25, 2024 07:56
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'JPlag Plagiarism Detector'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
61.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

uuqjz
uuqjz approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@uuqjz uuqjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsaglam tsaglam merged commit 6d21258 into develop Jun 25, 2024
44 checks passed
@tsaglam tsaglam deleted the feature/logger-changes branch June 25, 2024 08:20
@tsaglam tsaglam added this to the 6.0.0 milestone Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uuqjz uuqjz uuqjz approved these changes

Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tsaglam @uuqjz