-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display Basecode in report viewer #1825
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor issues below. I tested the feature, and it looks good. However, currently, the basecode bubble in the breadcrumb bar is not clickable; this might confuse users, not sure. What are your thoughts on that?
core/src/main/java/de/jplag/reporting/jsonfactory/BaseCodeReportWriter.java
Show resolved
Hide resolved
core/src/main/java/de/jplag/reporting/jsonfactory/BaseCodeReportWriter.java
Show resolved
Hide resolved
core/src/main/java/de/jplag/reporting/reportobject/ReportObjectFactory.java
Show resolved
Hide resolved
core/src/main/java/de/jplag/reporting/jsonfactory/ComparisonReportWriter.java
Outdated
Show resolved
Hide resolved
I though about implementing that, but didnt know what to do when the basecode is split into multiple parts |
Co-authored-by: Timur Sağlam <[email protected]>
Co-authored-by: Timur Sağlam <[email protected]>
Good question, either jump to the first one, or we keep it unclickable. We can also discuss this in our meeting, maybe somebody else has a good idea. |
Things to check:
|
|
|
Basecode now gets displayed in the report viewer.

In the report there now is a new folder called basecode with one file per submission.
In the report viewer they get converted into the same structure as regular matches, when displaying a comparison.
A hint for the color is included in the match list
