Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added generic catch clause in the c language module #1691

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

TwoOfTwelve
Copy link
Contributor

@TwoOfTwelve TwoOfTwelve commented Apr 9, 2024

Makes sure all exceptions thrown by the Java-CC parser are caught and wrapped in a JPlag exception. This ensures, that the exception shown to the user contains the file, that the parser to fail.

Similar to #1480

…ssages always contain the file that caused the error.
@TwoOfTwelve TwoOfTwelve requested a review from tsaglam April 9, 2024 08:52
@tsaglam tsaglam added bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change language PR / Issue deals (partly) with new and/or existing languages for JPlag labels Apr 10, 2024
Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only the PR description needs to be filled.

Copy link

sonarcloud bot commented Apr 23, 2024

@tsaglam tsaglam merged commit 95663ed into develop Apr 24, 2024
35 checks passed
@tsaglam tsaglam deleted the feature/c-language-catch-exceptions branch April 24, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue/PR that involves a bug language PR / Issue deals (partly) with new and/or existing languages for JPlag minor Minor issue/feature/contribution/change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants